buffer: byte consumers through scoped access; delete detached registry, latch and u32 cache (B2c part 1) by proggeramlug · Pull Request #12108 · PerryTS/perry

proggeramlug · 2026-10-06T17:38:27Z

Refs #11919. Buffer slice B2c, part 1 (BUFFER-DESIGN.md; owner decision 85). Builds on B1 (#12103).

Removes:

74 raw Buffer-layout access sites across the runtime (42), stdlib (27), updater (2), ext-http (1), ext-net (1), and the stream chunk reader that streams: native-payload stream hooks; stream methods on prototypes; node write semantics (G1/G2) #12104 added. They now go through the buffer::bytes scoped API.
DETACHED_BUFFER_REGISTRY, EVER_DETACHED and INLINE_OWNING_U32_CACHE.
The layout ratchet goes from 284 to 282 sites, with 0 new.

Still to come (B4 + B4c, a separate lane): the single cell layout, the codegen switch, and the remaining 5 tables, 2 latches and 2 caches.

Tests (on main 899aecd):

runtime 5184/0; codegen, ffi and ext-zlib all pass;
stdlib 258 pass, with the same 2 thread-exit failures as main;
gap subset (buffer/typed/dataview/arraybuffer/zlib/crypto/tls/net/http/fs): 0 regressions;
byte, view, detach, transfer, concat and crypto witnesses: 16 sabotages red;
native AddressSanitizer witnesses: 13 sabotages red;
source gate: 9 sabotages red.

Programs: all 7 match node. tsc −0.01% and fastify −0.02% instructions; the others are within noise. The earlier full A/B on the pre-rebase base was flat or better on all 14 programs and kernels (worker_heavy −0.64% instructions, −1.8 MB RSS).

…er metadata

…ent archives

coderabbitai · 2026-10-06T17:40:30Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5cd9e059-010f-4628-a606-91e21b158fe3

📥 Commits

Reviewing files that changed from the base of the PR and between 899aecd and 1dea925.

⛔ Files ignored due to path filters (1)

scripts/buffer_b4_census_closed.tsv is excluded by !**/*.tsv

📒 Files selected for processing (91)

changelog.d/PENDING-buffer-b2c-b4.md
crates/perry-ext-http/src/server/http2_server/session.rs
crates/perry-ext-net/src/tls.rs
crates/perry-runtime/src/array/header.rs
crates/perry-runtime/src/array/iter_methods.rs
crates/perry-runtime/src/atomics.rs
crates/perry-runtime/src/bigint/convert.rs
crates/perry-runtime/src/buffer/backing.rs
crates/perry-runtime/src/buffer/bytes.rs
crates/perry-runtime/src/buffer/detach.rs
crates/perry-runtime/src/buffer/header.rs
crates/perry-runtime/src/buffer/view.rs
crates/perry-runtime/src/builtins/formatting.rs
crates/perry-runtime/src/builtins/formatting/array_buffer.rs
crates/perry-runtime/src/builtins/formatting/typed_array_equality.rs
crates/perry-runtime/src/builtins/globals.rs
crates/perry-runtime/src/bun_compat/mod.rs
crates/perry-runtime/src/bun_ffi/call.rs
crates/perry-runtime/src/bun_ffi/memory.rs
crates/perry-runtime/src/child_process/v8_serde.rs
crates/perry-runtime/src/child_process/value_util.rs
crates/perry-runtime/src/dgram/net.rs
crates/perry-runtime/src/fs/dir_glob_watch/watch.rs
crates/perry-runtime/src/fs/dirent.rs
crates/perry-runtime/src/fs/fd_ops.rs
crates/perry-runtime/src/fs/filehandle.rs
crates/perry-runtime/src/fs/mod.rs
crates/perry-runtime/src/fs/stream.rs
crates/perry-runtime/src/fs/stream/write_file_input.rs
crates/perry-runtime/src/gc/census.rs
crates/perry-runtime/src/gc/tests/buffer_b4.rs
crates/perry-runtime/src/gc/tests/buffer_side_tables.rs
crates/perry-runtime/src/gc/tests/mod.rs
crates/perry-runtime/src/gc/types.rs
crates/perry-runtime/src/json/stringify_buffer.rs
crates/perry-runtime/src/node_api_host/buffers.rs
crates/perry-runtime/src/node_stream/native_hooks.rs
crates/perry-runtime/src/node_submodules/blob.rs
crates/perry-runtime/src/node_submodules/consumers.rs
crates/perry-runtime/src/node_v8.rs
crates/perry-runtime/src/node_vm.rs
crates/perry-runtime/src/object/buffer_dispatch.rs
crates/perry-runtime/src/object/global_this_webassembly.rs
crates/perry-runtime/src/object/native_module_crypto_key_object.rs
crates/perry-runtime/src/object/native_module_crypto_random.rs
crates/perry-runtime/src/object/shape_rule3.rs
crates/perry-runtime/src/object/typed_array_proto_thunks.rs
crates/perry-runtime/src/os_process_stream_write.rs
crates/perry-runtime/src/os_process_stream_write_tests.rs
crates/perry-runtime/src/os_process_streams.rs
crates/perry-runtime/src/symbol.rs
crates/perry-runtime/src/symbol/constructors.rs
crates/perry-runtime/src/text.rs
crates/perry-runtime/src/thread/clone_read.rs
crates/perry-runtime/src/thread/clone_write.rs
crates/perry-runtime/src/tls.rs
crates/perry-runtime/src/typedarray/mod.rs
crates/perry-runtime/src/typedarray/thread_exit_tests.rs
crates/perry-runtime/src/url/node_compat.rs
crates/perry-runtime/src/wasi.rs
crates/perry-runtime/src/webassembly.rs
crates/perry-stdlib/src/crypto.rs
crates/perry-stdlib/src/crypto/bytes_contract_tests.rs
crates/perry-stdlib/src/crypto/kdf.rs
crates/perry-stdlib/src/crypto/random.rs
crates/perry-stdlib/src/crypto/sign.rs
crates/perry-stdlib/src/crypto/util.rs
crates/perry-stdlib/src/ethers.rs
crates/perry-stdlib/src/querystring.rs
crates/perry-stdlib/src/sqlite/backup.rs
crates/perry-stdlib/src/sqlite/bind.rs
crates/perry-stdlib/src/sqlite/node_db.rs
crates/perry-stdlib/src/sqlite/node_stmt_session.rs
crates/perry-stdlib/src/streams.rs
crates/perry-stdlib/src/streams/byob.rs
crates/perry-stdlib/src/string_decoder.rs
crates/perry-stdlib/src/tls.rs
crates/perry-stdlib/src/tls/module_api.rs
crates/perry-stdlib/src/webcrypto/key_object.rs
crates/perry-stdlib/src/webcrypto/util.rs
crates/perry-updater/src/core.rs
scripts/buffer_b4_gap.py
scripts/buffer_b4_validate.py
scripts/buffer_layout_baseline.json
scripts/check_buffer_layout.py
scripts/fixtures/buffer_b4_ecs_u32.ts
scripts/fixtures/buffer_b4_measurements.json
scripts/fixtures/buffer_b4_verification.json
scripts/gc_runtime_root_holders.json
scripts/run_lint_gates.sh
test-files/test_gap_buffer_b4_detach_during_zlib.ts

 _______________________________
< The only circle I like is CI. >
 -------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Ralph Küpper added 23 commits October 6, 2026 16:02

Route byte consumers through scoped access and remove compatible buff…

38c5263

…er metadata

Finish updater byte access and make buffer verification consume coher…

ac8dd21

…ent archives

Strengthen concat ownership and close final native byte accesses

a519514

Root concat witnesses through their final construction allocation

3dce159

Bound concurrent buffer verification compiler workers

2888f85

Keep buffer lint gates reachable after CI checkout changes

8d443ce

Preserve THP-off trials and contain profiler artifacts

a284a68

Route persistent symbol pins through the shared GC setter

d7eff73

Separate anonymous and file RSS in buffer measurements

4c08ec3

Record closed census rows and explicit layout boundary

43328ab

Count GC cycles from the structured trace companion runs

3b525c3

Bound gap compiler workers during shared-host verification

812eb3f

Track the refreshed main and B1 verification baselines

32f153f

Record interleaved measurements and structured GC counts

ee85308

Explain teardown, page-layout and worker-pressure deltas

1c9acc0

Record final crate and gap parity for the 2fb54a baseline

73278b2

Refresh B1 and audit the new main verifier and test reads

265f624

Bound native emitter workers in the verification harness

3f68100

Record current-main crate, gap, sabotage and native ASan evidence

1551845

Record refreshed real-program and kernel measurements

fe9757d

Keep the newest B1 FFI witness on scoped byte access

2614cb5

Record current-main THP-off verification and finalize lane evidence

e676be9

Convert the native stream chunk reader to scoped byte access

1dea925

proggeramlug merged commit e87628e into main Oct 6, 2026
23 of 25 checks passed

proggeramlug deleted the buffer-b2c-consumers branch October 6, 2026 17:40

proggeramlug mentioned this pull request Oct 6, 2026

node:sqlite on native payloads; cheaper native callback path; statements own their sqlite3_stmt #12109

Merged

Navigation Menu

Repository navigation

buffer: byte consumers through scoped access; delete detached registry, latch and u32 cache (B2c part 1) - #12108

buffer: byte consumers through scoped access; delete detached registry, latch and u32 cache (B2c part 1)#12108
proggeramlug merged 23 commits into
mainfrom
buffer-b2c-consumers

proggeramlug commented Oct 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

proggeramlug commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

proggeramlug commented Oct 6, 2026 •

edited

Loading